ad-m commented on a change in pull request #18105:
URL: https://github.com/apache/superset/pull/18105#discussion_r788660586
##########
File path: superset-frontend/src/explore/components/RowCountLabel.tsx
##########
@@ -31,11 +31,20 @@ const propTypes = {
loading: PropTypes.bool,
};
Review comment:
Thanks for the clarification. I am not fully aware of project standards
whether `propTypes` is not used in an unusual way, and [have found TypeScript
components in
Superset](https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx)
to retain `propTypes` sometime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
