rumbin commented on issue #18085: URL: https://github.com/apache/superset/issues/18085#issuecomment-1019081142
@agusfigueroa-htg having the column matching if dashboard filters case-insensitive is a quick win in my eyes. However, some edge cases remain: 1. When filters are handled in Jinja, users will need to implement their own case-insensitivity. 2. When users convert a physical to a virtual dataset, or vice versa, the column case will flip, causing possible bugs. Such a conversation may be needed, e.g., when the source model now includes soft deletes which then need to be filtered out, or, the other way round, when it is decided to convert a virtual dataset into a table or view. 3. Users might be confused by the case inconsistency and they might not be aware of the case-insensitivity of the filters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
