michael-s-molina commented on a change in pull request #18102:
URL: https://github.com/apache/superset/pull/18102#discussion_r790618794
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -89,6 +89,12 @@ export interface SelectProps extends PickedSelectProps {
* False by default.
* */
allowNewOptions?: boolean;
+ /**
Review comment:
This comment should be generic. When you say something like `to prevent
dropdown movement onscroll` you are limiting its uses.
You could use the Ant Design docs for this prop:
> Parent Node to which the selector should be rendered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
