eschutho commented on a change in pull request #17944:
URL: https://github.com/apache/superset/pull/17944#discussion_r791287828
##########
File path: superset-frontend/src/SqlLab/components/ResultSet/index.tsx
##########
@@ -95,7 +95,7 @@ interface ResultSetProps {
showSql?: boolean;
visualize?: boolean;
user: UserWithPermissionsAndRoles;
- defaultQueryLimit: number;
+ defaultQueryLimit?: number;
Review comment:
yeah, let's play it safe and pass one in and leave the value as
required. 1000 is a good number. thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
