michael-s-molina opened a new pull request #18181: URL: https://github.com/apache/superset/pull/18181
### SUMMARY The objective of this PR is to fix the long URL problem In Explore. We had a function called `getExploreLongUrl` in `src/explore/exploreUtils` that was responsible for generating a URL with the contents of `form_data`. That was problematic because `form_data` can contain a lot of data which resulted in URL length-related errors. To fix this problem, https://github.com/apache/superset/pull/18151 created an endpoint called `/explore/form_data` where we can store this information on the server-side. This PR uses this endpoint to store `form_data` information and only keeps the generated key in the URL. Another objective of the PR is to maintain backward compatibility with previously generated short URLs. The `/explore` endpoint is using the old API and it contains a lot of complex logic related to the features in Explore so is NOT an objective of this PR to make big refactors that can potentially introduce regressions. I tried to preserve the original endpoint with the added feature. We should tackle this work in follow-up PRs, probably during the migration for the new API. There's another function in `src/explore/exploreUtils` called `getExploreUrl` that transfers a pruned version of `form_data` using the URL and it's being used by the legacy charts and filter boxes. This will be tackled in another PR as it involves possible soon-to-be deprecated code. We also have an endpoint called `/explore_json` that has the potential of being replaced by the new `/explore/form_data` endpoint but requires significant refactoring. This change is not in the scope of this PR. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF TODO ### TESTING INSTRUCTIONS TODO ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
