villebro edited a comment on pull request #18162: URL: https://github.com/apache/superset/pull/18162#issuecomment-1022906760
> Looks good to me. There is a break change that removes the default bolding emphasis effect in the line chart. https://apache.github.io/echarts-handbook/en/basics/release-note/5-3-0/#removing-the-default-bolding-emphasis-effect-in-the-line-chart. Should we need to adapt it? Although I think it's not important. @stephenLYZ yes, good catch. I noticed it and actually thought it kind of looked cleaner, but I agree we should probably propose changing it in a separate PR and retain feature parity in this PR 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
