kgabryje opened a new pull request #18216: URL: https://github.com/apache/superset/pull/18216
### SUMMARY When the label formatting was deciding whether to use number formatter or time formatter, it first checked if value is a number and if not, it checked if value is Date or column type is temporal. Timestamp values are numbers, so the first condition was true and number formatter was being used for timestamps. This PR switches the order of checks so that we first check if column is temporal. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: see linked issue After:  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Create a Pie chart 2. Select a temporal column as group by 3. Verify that label names are formatted properly ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [] Has associated issue: #13293 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @rusackas https://app.shortcut.com/preset/story/34104/gh-13293-prod-37-pie-chart-date-format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
