lyndsiWilliams commented on a change in pull request #17944:
URL: https://github.com/apache/superset/pull/17944#discussion_r794504709
##########
File path: superset-frontend/src/SqlLab/types.ts
##########
@@ -82,3 +97,31 @@ export interface QueryEditor {
errors: SupersetError[];
};
}
+
+// state refers to
superset-frontend/src/components/MessageToasts/getToastsFromPyFlashMessages.js
and superset-frontend/src/components/MessageToasts/actions.ts
+export type toastState = {
+ id: string;
+ toastType: ToastType;
+ text: string;
+ duration: number;
+ noDuplicate: boolean;
+};
+
+/** Root state of redux */
Review comment:
Same as above, I think the code explains well enough without needing a
comment.
##########
File path: superset-frontend/src/SqlLab/types.ts
##########
@@ -82,3 +97,31 @@ export interface QueryEditor {
errors: SupersetError[];
};
}
+
+// state refers to
superset-frontend/src/components/MessageToasts/getToastsFromPyFlashMessages.js
and superset-frontend/src/components/MessageToasts/actions.ts
Review comment:
I think the code explains well enough without needing this comment,
could you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
