villebro commented on a change in pull request #18215:
URL: https://github.com/apache/superset/pull/18215#discussion_r795693725
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -260,7 +260,7 @@ export const ControlPanelsContainer = (props:
ControlPanelsContainerProps) => {
// re-render, we only run this when the chart plugin explicitly ask for
this.
...(config.mapStateToProps?.length === 3
? // @ts-ignore /* The typing accuses of having an extra parameter. I
didn't remove it because I believe it could be an error in the types and not in
the code */
- config.mapStateToProps(exploreState, controls[name], chart)
+ config.mapStateToProps(props.exploreState, controls[name], chart)
Review comment:
nit: could we move this to line 249?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
