ktmud commented on a change in pull request #18182:
URL: https://github.com/apache/superset/pull/18182#discussion_r797829913
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -516,10 +516,12 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
}
});
+ const shouldEnableForceScreenshot = contentType === 'chart' && !isReport;
const data: any = {
...currentAlert,
type: isReport ? 'Report' : 'Alert',
- force_screenshot: forceScreenshot ? 'true' : 'false',
+ force_screenshot:
+ shouldEnableForceScreenshot || forceScreenshot ? 'true' : 'false',
Review comment:
Can we change this to `boolean` and update line 520 to `const data:
AlertObject` while we are here?
cc @betodealmeida @lyndsiWilliams
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
