villebro commented on a change in pull request #18569:
URL: https://github.com/apache/superset/pull/18569#discussion_r799629195
##########
File path: superset-frontend/src/explore/components/DataTableControl/index.tsx
##########
@@ -97,6 +115,126 @@ export const RowCount = ({
/>
);
+enum FormatPickerValue {
+ Formatted,
+ Epoch,
Review comment:
nit: with the new "Original value" label, this should probably be
`Original`
##########
File path: superset/views/core.py
##########
@@ -449,10 +449,16 @@ def get_raw_results(self, viz_obj: BaseViz) ->
FlaskResponse:
payload = viz_obj.get_df_payload()
if viz_obj.has_error(payload):
return json_error_response(payload=payload, status=400)
- return self.json_response({"data": payload["df"].to_dict("records")})
+ return self.json_response(
+ {
+ "data": payload["df"].to_dict("records"),
+ "colnames": payload["colnames"],
Review comment:
Do we need to make this `get`, just in case?
```suggestion
"colnames": payload.get("colnames"),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
