villebro commented on issue #13398:
URL: https://github.com/apache/superset/issues/13398#issuecomment-1031144349


   I can confirm this is not yet available. In a sense adding this feature 
isn't very difficult: The `Select` component already supports having different 
labels and values, and adding it to the filter component is relatively trivial. 
However, I'm more concerned with the following aspects of this feature:
   1) The native filter control panel has already grown way out of proportion, 
and we'd need to generalize it some more so that it would be more similar to 
the Explore control panel. I didn't yet check, but I fear adding this dropdown 
to the Value filter would require yet another if/then/else to the filter config 
modal.
   2) If the user chooses a combination of value and label columns that aren't 
1-1 mapped, the user may get very strange behavior. To avoid confusing error 
states, we would probably need to verify that all value/label pairs are 
strictly 1-1.
   
   I'm most concerned with 1), but as I haven't worked on this area for a while 
I'm not sure if this is a valid concern. @michael-s-molina , do you know if we 
could easily add an optional column label selector to the Value filter without 
adding more tech debt to the filter config modal?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to