stephenLYZ commented on a change in pull request #18603: URL: https://github.com/apache/superset/pull/18603#discussion_r801290739
########## File path: superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts ########## @@ -84,6 +84,7 @@ export function transformSeries( thresholdValues?: number[]; richTooltip?: boolean; }, + rawSeriesB?: SeriesOption[], Review comment: I think it makes sense. However, I have a concern that since the label color is specified by colorScale function, there may be some problem if user wants to set the custom label colors. User may not know how to set the label color of the chart B in this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org