betodealmeida commented on a change in pull request #18562:
URL: https://github.com/apache/superset/pull/18562#discussion_r801958104
##########
File path: tests/unit_tests/dashboards/commands/importers/v1/utils_test.py
##########
@@ -16,7 +16,7 @@
# under the License.
# pylint: disable=import-outside-toplevel, unused-argument
-from typing import Any, Dict
+from typing import Any, cast, Dict
Review comment:
This can go, right?
```suggestion
from typing import Any, Dict
```
##########
File path: superset/dashboards/commands/importers/v1/utils.py
##########
@@ -134,6 +134,12 @@ def update_id_refs( # pylint: disable=too-many-locals
if dataset_uuid:
target["datasetId"] =
dataset_info[dataset_uuid]["datasource_id"]
+ scope_excluded = native_filter.get("scope", {}).get("excluded", [])
+ if scope_excluded:
+ native_filter["scope"]["excluded"] = [
+ id_map[old_id] for old_id in native_filter["scope"]["excluded"]
Review comment:
Nit:
```suggestion
id_map[old_id] for old_id in scope_excluded
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
