villebro opened a new pull request #18633: URL: https://github.com/apache/superset/pull/18633
### SUMMARY When exporting a pivoted CSV for the Pivot v2 chart with columns or metrics that have a verbose name, the export fails. This adds the option of passing the `verbose_map` from the datasource to the `get_column_name` and `get_metric_name` util functions + adds some missing tests. Note that remapping the column names is usually not needed, hence mapping is optional. ### TESTING INSTRUCTIONS 1. Create a Pivot v2 using the FCC 2018 Survey example dataset 2. Set the metric as the saved metric "Count(*)" 3. Set the columns as "Job location preference" 4. Set the rows as "Willing to relocate" 5. Export a Pivoted CSV and observe a 500 ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
