[GitHub] [superset] geido commented on pull request #17792: feat: improve color consistency

Fri, 11 Feb 2022 06:02:29 -0800 


geido commented on pull request #17792:
URL: https://github.com/apache/superset/pull/17792#issuecomment-1036243298


   Hey @stephenLYZ some comments after additional testing.
   
   I had three charts sharing labels and the colors look right with using the 
Lyft Colors scheme. I removed two of the charts, leaving just one. Then I added 
back another chart that shared labels with the remaining one and the colors are 
not the same any longer. Check the screenshot.
   
   Even after changing the color scheme the label colors still look incorrect 
for the first chart. It's like at some point it got ignored.
   
   You can see this behavior in Dashboard 
http://54.202.2.94:8080/superset/dashboard/12 that I'll leave untouched on the 
test env for you to reproduce the problem.
   
   <img width="1666" alt="Screen Shot 2022-02-11 at 15 44 36" 
src="https://user-images.githubusercontent.com/60598000/153602336-08ef3bf9-7750-4def-9d8c-d4fdad586d44.png";>
   
   In a Dashboard where no color scheme is used, I see that the same labels do 
not share the same colors. I am not sure if this is the wanted behavior but 
probably worth checking
   
   <img width="1115" alt="Screen Shot 2022-02-11 at 15 54 27" 
src="https://user-images.githubusercontent.com/60598000/153604073-4af7ab0d-1bef-4326-854c-ba86fc37dea2.png";>
   
   For some reason, in that same Dashboard without color scheme, after applying 
the Lyft Colors color scheme, the label colors of the first chart are different 
from the others. I was under the assumption that with changing the color scheme 
the label colors would be regenerated, but it looks like this does not happen 
for the first chart for some reasons. You can check that behavior here 
http://54.202.2.94:8080/superset/dashboard/11. I think it's the same problem as 
the first point above.
   
   <img width="925" alt="Screen Shot 2022-02-11 at 15 58 16" 
src="https://user-images.githubusercontent.com/60598000/153604523-a6d713db-9b82-4097-aa8e-a4ed446aca46.png";>
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to