ra002890 opened a new pull request #18682:
URL: https://github.com/apache/superset/pull/18682
feat: It is possible to pass attributes to embedded iframe in embedded-sdk
### SUMMARY
It must be possible to control the embedded iframe inserted by the
embedded-sdk. With this change we can pass any html attribute to it, including
id.
### TESTING INSTRUCTIONS
1. Pass a map containing keys(html attribute names) and values(html
attribute values) to the parameter iframeAttributes of EmbedDashboardParams.
2. Check on the rendered page if the iframe got passed attributes.
```javascript
embedDashboard({
id: "8", // given by the Superset embedding UI
supersetDomain: "http://127.0.0.1:9000";,
mountPoint: document.getElementById("my-superset-container")!,
// any html element that can contain an iframe
iframeAttributes: new Map<string, string>([["id",
"my-test-frame"], ["className", "my-test-frame-class"]]),
fetchGuestToken: () => fetchGuestTokenFromBackend(),
});
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
