[GitHub] [superset] kgabryje opened a new pull request #18712: feat(dashboard): Implement empty states for dashboard

[GitBox]

kgabryje opened a new pull request #18712:
URL: https://github.com/apache/superset/pull/18712


   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   This PR implements chart empty states for 3 scenarios:
   
   1. Dashboard has no components added
   2. Dashboard is in edit mode and has no components added yet
   3. Native filters bar is empty
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1792" alt="image" 
src="https://user-images.githubusercontent.com/15073128/153859190-ebc9d41a-d4dd-4796-9572-0e4dc1d8dd40.png";>
   
   <img width="1792" alt="image" 
src="https://user-images.githubusercontent.com/15073128/153860494-6252c786-1bd8-4f60-8059-a29620b069a6.png";>
   
   ### TESTING INSTRUCTIONS
   1. Create a dashboard
   2. Verify that there is an empty state in native filters bar when there are 
no native filters added
   3. Verify that there is an empty state in the middle of the dashboard when 
there are no components added
   4. Go to edit mode and verify that there is an empty state when there are no 
components added
   5. Click the button "Create a new chart" button in edit mode's empty state 
and verify that it redirects you to chart creator
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC @kasiazjc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org