eschutho commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r806339149
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -113,9 +125,28 @@ const RightMenu = ({
}
icon={<Icons.TriangleDown />}
>
- {dropdownItems.map(
- menu =>
- findPermission(menu.perm, menu.view, roles) && (
+ {dropdownItems.map(menu => {
+ if (menu.label === 'Data') {
Review comment:
Ok, I see what you're saying. It looks like the RightMenu component is
largely hardcoded on the client side. Do we need to pass those submenu values
in from the backend? We can add anything needed for toggling whether to show
the items in the `FRONTEND_CONF_KEYS` if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
