villebro opened a new pull request #18741: URL: https://github.com/apache/superset/pull/18741
### SUMMARY While writing docs for the Dashboard URL params, I noticed some inconsistencies in how they work: - The return type for `getUrlParam` was missing `null` which it defaults to when the param is missing - The dashboard always opens with the Filter Tab expanded. It should be collapsed if there are no filters. I believe this is a regression from #16992 - There was no way to disable native filters via URL params the same way that the dashboard metadata flag `show_native_filters` does. Here we recycle the `show_filters` URL param to mimic the behavior of `show_native_filters`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS 1. Go to a dashboard with no native filters. Notice that the Filter Tab opens up expanded. Set `expand_filters=1` on the URL to forcefully expand the Filter Tab 2. Go to a dashboard with at least 1 native filter and set `expand_filters=0` on the URL to forcefully collapse the Filter Tab 3. Go to a dashboard and set `show_filters=0` to forcefully disable native filters (handy for standalone mode) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
