pkdotson commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r807358474
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -113,9 +148,41 @@ const RightMenu = ({
}
icon={<Icons.TriangleDown />}
>
- {dropdownItems.map(
- menu =>
- findPermission(menu.perm, menu.view, roles) && (
+ {dropdownItems.map(menu => {
+ if (menu.label === 'Data') {
+ return (
+ <SubMenu
+ key="sub2"
+ className="data-menu"
+ title={menuIconAndLabel(menu as MenuObjectProps)}
+ >
+ {allowedExtensions?.csv_extensions && (
Review comment:
Would it make sense to hard code these because I have to check the
allowedExtensions bools? Otherwise I'll have to add a method and hash to check
if to render these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
