nytai edited a comment on pull request #18181: URL: https://github.com/apache/superset/pull/18181#issuecomment-1040942605
+1 on @john-bodley's concerns. I've been suffering some of the effects the long URL problem and I'm happy to see it being worked on, but I agree this design raises some concerns. Particularly troubling is that the files system cache seems to be the default, so users going to upgrade superset would likely discover this issue after deploying. Certain deployment setups involve running a single pod/host for dev/test/staging envs and multiple pods for production, so having the file system cache be the default would not present any issues in a single pod/host environment but would be a huge issue in multi-pod/multi-host environment. The form data request could get routed to a pod/host that does not have the data in file system cache. Additionally, this introduces a hard requirement on a cache service, where one didn't exist before (superset works fine with no cache configs). Storing in the metadata db seems like a better choice given that dependency has always existed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
