eschutho commented on a change in pull request #18629:
URL: https://github.com/apache/superset/pull/18629#discussion_r808456761
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -23,11 +23,38 @@ import { Link } from 'react-router-dom';
import Icons from 'src/components/Icons';
import findPermission from 'src/dashboard/util/findPermission';
import { useSelector } from 'react-redux';
-import { UserWithPermissionsAndRoles } from 'src/types/bootstrapTypes';
+import {
+ UserWithPermissionsAndRoles,
+ CommonBootstrapData,
+} from 'src/types/bootstrapTypes';
import LanguagePicker from './LanguagePicker';
import { NavBarProps, MenuObjectProps } from './Menu';
export const dropdownItems = [
+ {
Review comment:
if you were to define dropdownItems as `MenuObjectProps[]` here, would
typescript then not make you coerce it below on line 164?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
