suddjian opened a new pull request #18773:
URL: https://github.com/apache/superset/pull/18773


   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   If you have Superset open in the background and your session expires, the 
frontend will still display the logged-in state until the next request happens 
to fire, jarringly sending you all of a sudden to the login page.
   
   Until now.
   
   This code listens for the document's `visibilitychange` event. When the tab 
is focused, a request is made to the new `/api/v1/me/` endpoint, which returns 
401 if the user is not logged in. The SupersetClient detects the 401 and sends 
the user to the login page.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   
https://user-images.githubusercontent.com/1858430/154383754-abbf602a-543d-4fd1-b775-d3d795370a27.mov
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   Open Superset in two tabs. Log out of one tab. Switch to the other tab. It 
will immediately redirect to the login page.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to