ad-m commented on a change in pull request #18758:
URL: https://github.com/apache/superset/pull/18758#discussion_r808619132



##########
File path: superset/views/database/views.py
##########
@@ -130,24 +130,29 @@ def form_get(self, form: CsvToDatabaseForm) -> None:
 
     def form_post(self, form: CsvToDatabaseForm) -> Response:
         database = form.con.data
-        csv_table = Table(table=form.name.data, schema=form.schema.data)
+
+        if "." in form.name.data:

Review comment:
       This is a detail, but I think it is worth moving the format checking to 
a separate method / function, so that the name of the method says what you 
really want to check and hide the implementations here to improve readability. 
It currently says you want to check if it contains a period, but in fact you 
are checking to see if it contains a namespace.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to