Yann-J opened a new pull request #18778: URL: https://github.com/apache/superset/pull/18778
While contributing some new maps to the legacy country map visualization in #, I realized a few limitations, that this PR intends to address, i.e.: - Support a new source to download high-quality geoJSON boundary files, the amazing [geoBoundaries](https://www.geoboundaries.org/index.html) - in particular, this source supports up to 4 levels of administrative divisions (whereas the current source only supports 1), thanks to a new python notebook - Support for an attribution in the map display - Better naming convention for map names, e.g. capitalizing every word in names with spaces - A bunch of new maps coming from geoBoundaries relevant to my organization, with several administrative subdivision levels ### SUMMARY Technical / design choices and caveats: - The attributions comment displayed in the map is read from the GeoJSON source's `attribution` property at the top level of the `FeatureCollection`. - __WARNING__: Many admin areas do not have an ISO code... The geoBoundaries datasource's ID is used instead, but it requires the user to know about these. Further improvements might be needed to allow the use of the area name instead, or make it easier to discover the expected codes... ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Sample map for Kenya Counties (notice the new attribution comment at the bottom):  Snapshot of all the added geojson maps:  ### TESTING INSTRUCTIONS Set up a data source with county/province-level data, including their ISO 3166-2 code, for instance uploading this sample random CSV: ``` ISO,name,value ET-AA,Addis Ababa,58.24388052899692 ET-AF,Afar,82.39096125651662 ET-AM,Amhara,5.823758668250489 ET-BE,Beneshangul Gumu,4.906103785510196 ET-DD,Dire Dawa,64.04758252062041 ET-GA,Gambela,71.45936608261624 ET-HA,Hareri,6.278288599268822 ET-OR,Oromia,60.625174539397065 ET-SN,SNNPR,93.6721133500065 ET-SO,Somali,59.03513300561172 ET-TI,Tigray,34.66035278225454 ``` Create a new Country Map chart with this dataset (in this example, for the 'Ethiopia Regions' country name). ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
