villebro opened a new pull request #18780: URL: https://github.com/apache/superset/pull/18780
### SUMMARY This PR is not meant to be merged just yet - currently only here for discussion. Right now the ECharts area chart doesn't stack by default, often leading to confusion. This changes the default behavior to set stacking to true when switching to the ECharts area chart. In addition, it turns out we don't support stacking on the line chart, which is in line with how Google Sheets does it. Incidentally, "Area Chart" and "Stacked Area Chart" are two separate chart types both ton Google Sheets and Excel. This is also the case for bar charts. So a follow-up question is, would it be more intuitive to have separate stacking charts, or should stacking be a control in the parent chart? A few options come to mind: Option 1: Maintain the current status quo: - Line charts can't be stacked - Stacking in area and bar charts default to false - When setting stacking to true and moving from area to bar chart, the bars appear stacked. Option 2: Introduce separate chart types for the stacking variants: - Area Chart - Stacked Area Chart (new) - Bar Chart - Stacked Bar Chart (new) - Line Chart - Stacked Line Chart (new) - etc Option 3: Assume that stacking is an inherent viz type option that should be reset to its default when going between chart types: - Area Chart (stacking = true?) - Bar Chart (stacking = false?) - Line Chart (stacking unavailable? or add stacking and default to false?) ### Video This demonstrates option 2: https://user-images.githubusercontent.com/33317356/154436935-70448695-3b56-4c15-9cc2-1aa165f33e50.mp4 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
