gokhansari commented on issue #17187: URL: https://github.com/apache/superset/issues/17187#issuecomment-1042907319
Thank you @suddjian for the proposal and your commits. It'll be life saver. There is one thing that I would like to mention before you guys finalizing this feature. [Custom Url Parameters](https://superset.apache.org/docs/installation/sql-templating/#available-macros) feature is one of the handy functionalities and It is not dispensable. When I check the master branch, for now It seems Embedded SDK only takes dashboardID parameter. To be able to use `{{ url_param('custom_variable') }}` and reference It in dataset SQL queries, I think there should be an other SDK parameter like `url_params: string` as we all used to use a lot of url parameters. Example from doc: ``` www.example.com/superset/sqllab?countrycode=ES&language=EN SELECT count(*) FROM ORDERS WHERE country_code = '{{ url_param('countrycode') }}' AND language_code = '{{ url_param('language') }}' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
