sujiplr commented on a change in pull request #18746:
URL: https://github.com/apache/superset/pull/18746#discussion_r809731658
##########
File path: superset/db_engine_specs/base.py
##########
@@ -300,6 +299,16 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
# If True, then it will allow in subquery ,
# if False it will allow as regular CTE
allows_cte_in_subquery = True
+ # Whether allow LIMIT clause in the SQL
+ # If True, then the database engine is allowed for LIMIT clause
+ # If False, then the database engine is allowed for TOP clause
+ allow_limit_clause = True
+ # This list will give keywords for select statements
+ # to consider for the engines with TOP SQl parsing
+ select_keywords: Set[str] = None
+ # This list will give the keywords for data limit statements
+ # to consider for the engines with TOP SQl parsing
+ top_keywords: Set[str] = None
Review comment:
Corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
