[GitHub] [superset] zhaoyongjie edited a comment on pull request #18782: fix: contribution operator meets nan value

[GitBox]

zhaoyongjie edited a comment on pull request #18782:
URL: https://github.com/apache/superset/pull/18782#issuecomment-1044594731


   > LGTM with a non-blocking comment to think about (as this PR fixes a clear 
bug I consider my comment mostly a nit). Also, an unrelated observation: I 
wonder if we should rename "Total" to something that describes more clearly 
that it's actually the "row" or "x-axis" that we're calculating the 
contribution for, not the "total", which I feel would be calculated in relation 
to the sum of the matrix. <img alt="image" width="316" 
src="https://user-images.githubusercontent.com/33317356/154644101-ca1c15d7-6f31-410b-a7ae-36de05737311.png";>
   
   nice catch! done!
   
   <img width="719" alt="image" 
src="https://user-images.githubusercontent.com/2016594/154699002-85a905cd-3a06-4cb4-90ba-80b01339b9e4.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org