geido commented on a change in pull request #18773: URL: https://github.com/apache/superset/pull/18773#discussion_r810057394
########## File path: superset/users/api.py ########## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from flask import g, Response +from flask_appbuilder.api import BaseApi, expose, safe + +from .schemas import UserResponseSchema + +user_response_schema = UserResponseSchema() + + +class CurrentUserRestApi(BaseApi): + """ An api to get information about the current user """ + + resource_name = "me" + openapi_spec_tag = "Current User" + openapi_spec_component_schemas = (UserResponseSchema,) + + @expose("/", methods=["GET"]) + @safe + def me(self) -> Response: + """Get the user object corresponding to the agent making the request + --- + get: + description: >- + Returns the user object corresponding to the agent making the request, + or returns a 401 error if the user is unauthenticated. + responses: + 200: + description: The current user + content: + application/json: + schema: + type: object + properties: + result: + $ref: '#/components/schemas/UserResponseSchema' + 401: + $ref: '#/components/responses/401' + """ + if g.user is None or g.user.is_anonymous: Review comment: Oh ok I see what you are doing in the frontend to avoid this being requested for anon users `bootstrapData.user?.isActive`. I am thinking if this might confuse someone else when using this endpoint in some other places and if we might end up in that problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
