eschutho commented on a change in pull request #18722:
URL: https://github.com/apache/superset/pull/18722#discussion_r810259750
##########
File path: superset-frontend/src/views/components/MenuRight.tsx
##########
@@ -163,6 +198,15 @@ const RightMenu = ({
className="data-menu"
title={menuIconAndLabel(menu)}
>
+ <Menu.Item key={GlobalMenuDataOptions.DB_CONNECTION}>
+ Connect Database
+ </Menu.Item>
+ {SHOW_GLOBAL_GSHEETS && (
+ <Menu.Item key={GlobalMenuDataOptions.GOOGLE_SHEETS}>
+ Connect Google Sheet
+ </Menu.Item>
+ )}
+ <Menu.Divider />
Review comment:
I'd suggest since we have the data object above that we're looping over,
to try to move this into that data structure so that we can keep this as
modular as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
