AAfghahi commented on a change in pull request #18817:
URL: https://github.com/apache/superset/pull/18817#discussion_r810361393



##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.jsx
##########
@@ -401,6 +409,19 @@ class TabbedSqlEditors extends React.PureComponent {
       );
     });
 
+    const emptyTab = (
+      <EditableTabs.TabPane
+        key={Math.random()}
+        data-key={Math.random()}

Review comment:
       Yeah I was worried about hardcoding a number, but I think that you are 
right and that this would be the ebst way forward. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to