kzosabe commented on a change in pull request #18694:
URL: https://github.com/apache/superset/pull/18694#discussion_r810434572
##########
File path: superset/db_engine_specs/base.py
##########
@@ -1425,6 +1430,33 @@ def cancel_query( # pylint: disable=unused-argument
def parse_sql(cls, sql: str) -> List[str]:
return [str(s).strip(" ;") for s in sqlparse.parse(sql)]
+ @classmethod
+ def _humanize(cls, value: Any, suffix: str, category: Optional[str] =
None) -> str:
Review comment:
If there could be an input like (1000, "", "dollars") and an output like
"$1,000", there would be more categories
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
