villebro commented on a change in pull request #18746:
URL: https://github.com/apache/superset/pull/18746#discussion_r810818702
##########
File path: superset/db_engine_specs/mssql.py
##########
@@ -48,6 +48,9 @@ class MssqlEngineSpec(BaseEngineSpec):
limit_method = LimitMethod.WRAP_SQL
max_column_name_length = 128
allows_cte_in_subquery = False
+ allow_limit_clause = False
+ select_keywords = {"SELECT"}
+ top_keywords = {"TOP"}
Review comment:
these can be removed (they're identical to the defaults in
`BaseEngineSpec`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
