[GitHub] [superset] ktmud opened a new pull request #18852: fix(dashboard): incorrect chart error with slow dataset api request

[GitBox]

ktmud opened a new pull request #18852:
URL: https://github.com/apache/superset/pull/18852


   ### SUMMARY
   
   Fix a bug where sever side chart data query errors were displayed as "No 
results" when the `/dashboard/[id]/datasets` API is slow. 
   
   #### Background
   
   #15699 made loading full datasource info for Dashboard charts async, 
however, some chart types didn't handle incomplete datasource info properly, 
causing JS errors. #15993 fixed that by re-rendering the charts after the 
datasources are fully loaded. Then a “No results" state for dashboard chart 
container is introduced in 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   Charts with server side errors may show as "no results":
   
   <img width="729" alt="Xnip2022-02-22_11-17-46" 
src="https://user-images.githubusercontent.com/335541/155210656-f6a1e392-4579-4878-962a-bb9ba33b2840.png";>
   
   #### After
   
   Server side errors correctly rendered as unexpected errors:
   
   <img width="736" alt="Xnip2022-02-22_11-16-44" 
src="https://user-images.githubusercontent.com/335541/155210705-3f3b1e7f-585b-433f-a183-5c8b50146f69.png";>
   
   
   ### TESTING INSTRUCTIONS
   
   Here's how to reproduce the bug:
   
   1. Go to a dashboard where the dashboard/datasets API may be slow---e.g. 
dashboard that used a large dataset with a lot of columns
   2. Make sure users have access control error (or any other server side 
errors) when accessing one of the charts
   2. Refresh the page until you see the datasets API returns later than the 
chart data api:
       <img width="430" alt="Xnip2022-02-22_12-05-00" 
src="https://user-images.githubusercontent.com/335541/155210621-56c474c2-fd91-486c-bbdf-28d3ada20a6f.png";>
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org