[GitHub] [superset] ktmud opened a new pull request #18856: feat(select): sort exact and startsWith match to first

[GitBox]

ktmud opened a new pull request #18856:
URL: https://github.com/apache/superset/pull/18856


   ### SUMMARY
   
   Sort exact match and starsWith match in the Select component to top of the 
list. This improves the user experience when searching a very large list where 
a partial match may be sorted to the top only because it ranks higher in 
lexicographic order.
   
   https://github.com/apache/superset/pull/16414 tried to tackle this but the 
work was put on hold as the Select component was undergoing a significant 
migration and feature-enrichment. Now that it's more stable,  it's worth giving 
this problem another go.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   Partial match may be sorted to the top if it ranks higher alphabetically:
   
   <img width="372" alt="Xnip2022-02-22_13-26-49" 
src="https://user-images.githubusercontent.com/335541/155222372-6b43f547-c234-4f47-ad7f-c68095e89219.png";>
   
   
   #### After
   
   "Starts with" and exact matches always ranks higher, making it easier to 
search for and select things the users actually want:
   
   <img width="381" alt="Xnip2022-02-22_13-27-09" 
src="https://user-images.githubusercontent.com/335541/155222384-1b25d068-5451-4065-a2ca-50c59a4c139d.png";>
   
   
   
   ### TESTING INSTRUCTIONS
   
   Go to any Select component and search for things
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org