kasiazjc commented on pull request #18817: URL: https://github.com/apache/superset/pull/18817#issuecomment-1048864513
@AAfghahi thanks for working on this! and +1 to what @kgabryje said. I have 1 additional thing - in the designs when there are not tabs there is actually one active tab which contanins copy (Add a new tab) and the "+" icon. The spacings should be the same as in the normal cards. After clicking on "Add a new tab" the flow should be the same as before, so you have a tab with sql query's name and tab with only the "+" icon if that makes sense.  You implemented it as two different tabs which can cause confusion among the users and it causes some random error.  Can you merge those two tabs in empty state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
