betodealmeida commented on a change in pull request #17543: URL: https://github.com/apache/superset/pull/17543#discussion_r813478095
########## File path: superset/columns/models.py ########## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Column model. + +This model was introduced in SIP-68 (https://github.com/apache/superset/issues/14909), +and represents a "column" in a table or dataset. In addition to a column, new models for +tables, metrics, and datasets were also introduced. + +These models are not fully implemented, and shouldn't be used yet. +""" + +import sqlalchemy as sa +from flask_appbuilder import Model + +from superset.models.helpers import ( + AuditMixinNullable, + ExtraJSONMixin, + ImportExportMixin, +) + + +class Column( + Model, AuditMixinNullable, ExtraJSONMixin, ImportExportMixin, +): + """ + A "column". + + The definition of column here is overloaded: it can represent a physical column in a + database relation (table or view); a computed/derived column on a dataset; or an + aggregation expression representing a metric. + """ + + __tablename__ = "sl_columns" + + id = sa.Column(sa.Integer, primary_key=True) Review comment: Ah, I see your point. But the idea is that at least initially the APIs would be unchanged, we'd just reroute the backend to read from the new models instead of the old ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
