serenajiang opened a new pull request #18896: URL: https://github.com/apache/superset/pull/18896
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Sort `TimeTableViz` (time series table) by the first metric descending. Currently, no sorting is applied, so time series tables show the "first" n series, which can be confusing to users and isn't very helpful. Sorting by the first metric descending is more consistent with other chart types. Note time series tables do not have a sort by control - might be better to add this in the future, but this should still an improvement for now. ### TESTING INSTRUCTIONS Create time series viz. Confirm that an order by clause exists in the query. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API @john-bodley @ktmud ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
