dpgaspar commented on pull request #18753: URL: https://github.com/apache/superset/pull/18753#issuecomment-1049647099
> @dpgaspar do you recall offhand where the `List Users` and `List Roles` are set, and/or how we might override them? I'm assuming they're in a FAB Jinja template, or in a database somewhere. We want to make them sentence case (e.g. `List users` and `List roles`) per our design guidelines. The most straightforward way, would be overriding the role model view class from FAB, but unfortunately for the user's we have multiple classes to override (basically one per auth method). So we would need to override all these: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/security/views.py#L255. We have an ongoing PR on FAB https://github.com/dpgaspar/Flask-AppBuilder/pull/1801 for adding a CRUD view around the security APIs, a better long term path would be to leverage that and build the UI around those. IMO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
