etr2460 opened a new pull request #18934: URL: https://github.com/apache/superset/pull/18934
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY When you switch tabs in sql lab, we were keeping them all rendered in the dom, but hidden. This meant that everytime the sql lab redux state changed, we'd re-render all tabs that were viewed since the last page load. This prop is defined on antd tabs, and un-renders tabs that aren't currently selected, improving the perf of both switching tabs and updating the sql query being run. ### TESTING INSTRUCTIONS go to SQL Lab, change tabs and see the old tabs un-rendered from the DOM. Ensure all SQL Lab functionality still works to: @kgabryje @ktmud @rusackas @john-bodley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
