kgabryje commented on a change in pull request #18967:
URL: https://github.com/apache/superset/pull/18967#discussion_r816052271
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterCard/ScopeRow.tsx
##########
@@ -47,17 +47,16 @@ export const ScopeRow = React.memo(({ filter }:
FilterCardRowProps) => {
[elementsTruncated, scope],
);
- if (!Array.isArray(scope) || scope.length === 0) {
- return null;
- }
return (
<Row>
<RowLabel>{t('Scope')}</RowLabel>
<TooltipWithTruncation title={tooltipText}>
<RowValue ref={scopeRef}>
- {scope.map((element, index) => (
- <span>{index === 0 ? element : `, ${element}`}</span>
- ))}
+ {scope
Review comment:
This change was added in https://github.com/apache/superset/pull/18793
(in review), copying it here in order to write a test for it before #18793 is
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
