hughhhh commented on a change in pull request #18795:
URL: https://github.com/apache/superset/pull/18795#discussion_r816164785
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -1369,19 +1368,15 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
)}
</StyledRadioGroup>
</div>
- {isReport && (
- <div className="inline-container">
- <StyledCheckbox
- className="checkbox"
- checked={forceScreenshot}
- onChange={onForceScreenshotChange}
- >
- Ignore cache when generating screenshot
- </StyledCheckbox>
- </div>
- )}
</>
)}
+ <StyledCheckbox
Review comment:
it's not in the spec, personally think it is fine since we are
explicitly putting text right next to the checkbox
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
