villebro commented on pull request #18181: URL: https://github.com/apache/superset/pull/18181#issuecomment-1056467837
> After this change, when user clicks on the shorten url link from Dashboard and Explore view, do you plan to use the old /r/12345 shorten url functions, or generate a new hashed key? > > I kind of prefer to use old shorten url `/r/12345` for the permanent shorten link, since this will be consistent with old behavior. While hashed key url, it will be created and only used by explore view navigation, I assume most of hashed explore view urls will be abandoned, and it mean to be re-usable in relatively short term (when cache is available). So I prefer to make these 2 use cases clearly different. What do you think? @graceguo-supercat I would prefer to steer away from serial ids due to the security implications of them (trivial to guess/iterate through). However, I have an idea of how we can get the best of both worlds, so I'll make this optional in my proposal (=it will be possible to configure Superset to use either one). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
