cccs-Dustin commented on a change in pull request #18951:
URL: https://github.com/apache/superset/pull/18951#discussion_r817732608
##########
File path: superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.jsx
##########
@@ -260,8 +256,31 @@ class TabbedSqlEditors extends React.PureComponent {
: t(
'-- Note: Unless you save your query, these tabs will NOT persist if
you clear your cookies or change browsers.\n\n',
);
+
+ let newTitle;
+
+ if (this.props.queryEditors.length > 0) {
+ const untitledQueryNumbers = this.props.queryEditors
+ .filter(x => x.title.includes('Untitled Query '))
+ .map(x => x.title.replace('Untitled Query ', ''))
+ .filter(x => !Number.isNaN(Number(x)));
Review comment:
That seems like a much better way of only getting the query tabs with
the title "Untitled Query #". Thank you for the suggestion, I had added this
change to the latest commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
