kgabryje opened a new pull request #18998: URL: https://github.com/apache/superset/pull/18998
### SUMMARY When going from the dashboard to Explore view with extra filters (native filters or filter box), the filters are only appended to the first query. This PR iterates through form data and adds extra filters to every field that matches pattern `adhoc_filters.*`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: ![Uploading image.png…]() After: <img width="1792" alt="image" src="https://user-images.githubusercontent.com/15073128/156403586-b0fac9cf-1dbe-4b8c-91e6-c108801f0ef8.png";> ### TESTING INSTRUCTIONS 1. Create a mixed timeseries chart and add it to a dashboard 2. Go to that dashboard and apply some native filters 3. Click View chart in explore on mixed timeseries chart 4. Verify that native filter is applied in both Query A and Query B adhoc filter control ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #15858 - [ ] Required feature flags: - [ ] Changes UI - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [x] Migration is atomic, supports rollback & is backwards-compatible - [x] Confirm DB migration upgrade and downgrade tested - [x] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API DB migration stats: ``` Current: 0.42 s 10+: 0.44 s 100+: 0.26 s 1000+: 0.25 s ``` This PR replaces #18740 https://app.shortcut.com/preset/story/37242/explore-mixed-time-series-chart-native-filter-only-apply-to-query-a-but-not-query-b-when-open-mixed-time-series-chart-from -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/15073128/156403586-b0fac9cf-1dbe-4b8c-91e6-c108801f0ef8.png"](https://user-images.githubusercontent.com/15073128/156403586-b0fac9cf-1dbe-4b8c-91e6-c108801f0ef8.png"){kind=link}