rusackas commented on a change in pull request #18947:
URL: https://github.com/apache/superset/pull/18947#discussion_r819071547



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/utils/helper.ts
##########
@@ -0,0 +1,5 @@
+export const convertNumber = (value: string | number) => {
+  /* eslint radix: ["error", "as-needed"] */

Review comment:
       I was wondering the same. I think there's _some_ chance of it parsing 
some implicit octal radix, but I haven't stopped to try to break it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to