betodealmeida commented on pull request #19022: URL: https://github.com/apache/superset/pull/19022#issuecomment-1058693629
> wow.. that's a lot less code. :) Yeah! The original implementation was copied from the current `Database` model, but of course there we use `get_sqla_engine` for other things than just accessing the dialect. I should've realized it could've been done in a simpler way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
