ktmud commented on a change in pull request #18856:
URL: https://github.com/apache/superset/pull/18856#discussion_r819273808
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -577,7 +538,6 @@ const Select = ({
if (filterOption) {
const searchValue = search.trim().toLowerCase();
Review comment:
We should probably remove trimming and case insensitivity treatment at
this place since whitespaces and cases can be useful in search and ranking,
too. This is especially important if we are to pass the search query to some
more sophisticated backend search engine. For example, search "Le" may rank
"Leah" first, but "Le " (with a space at the end) should rank things like "Le
Monde" first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
